Opened 19 years ago
Closed 19 years ago
#2863 closed defect (fixed)
dvbrecorder drops a ts packet after discontinuity unnecessarily
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | dvb | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Changeset [11334] is incorrect, it drops valid data. The packet after the discontinuity is detected is valid. The correct action is to purge the uncomplete assembled packet of that PID in MPEGStreamData but the packet assembler code does that already.
I'm not sure what's the best solution: reverting [11334], removing the continuity check in dvbrecorder since it's not used atm or purging the incomplete packet since it'll save some cycles in mpegstreamdata.
Spotted by Dibblah on irc.
Note:
See TracTickets
for help on using tickets.
(In [12383]) Fixes #2863. Refs #2147. Reverts [11334], this threw away a possibly good TS packet if it followed a lost TS packet.
(I had both #2858 and & #2863 open in the my browser when I made the commit and copied the wrong number into the fixed column.)