Opened 20 years ago
Closed 20 years ago
Last modified 19 years ago
#37 closed patch (fixed)
mythgallery should use myth_system instead of system
| Reported by: | Robert Tsai <rtsai1111> | Owned by: | Isaac Richards |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.19 |
| Component: | mythgallery | Version: | head |
| Severity: | high | Keywords: | |
| Cc: | Ticket locked: | no |
Description
mythgallery uses system("mplayer ...") to generate thumbnails for movie files.
This appears to cause some tty-related hangs from not closing stdin, etc. Recovering requires killing -9 mythfrontend, etc., which still leaves behind mplayer as a zombie.
Replacing these calls with myth_system makes the problem go away (and yields properly-generated thumbnails for movie files).
Attachments (1)
Change History (5)
comment:1 by , 20 years ago
comment:2 by , 20 years ago
| Type: | defect → patch |
|---|
by , 20 years ago
| Attachment: | mythgallery.system.diff added |
|---|
comment:3 by , 20 years ago
(I've verified that the thumbgallery.cpp fix works. The iconview.cpp changes are just for good measure; they shouldn't hurt, right?)
Note:
See TracTickets
for help on using tickets.
Forget what I said about the zombies, they were actually wedged by gdb :).
But using system() still leaves mplayer hung waiting for stdin, and still requires kill -9 to recover.