Opened 19 years ago
Closed 19 years ago
#3788 closed enhancement (fixed)
instead of deleting a show, mark it for auto-expire and put in a "deleted" group
| Reported by: | skamithi | Owned by: | skamithi |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythtv | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
there was talk on irc/alias a little while ago (i think) about doing something like this.
been using this patch for about a week and i like it.
when you attempt to delete the show, it is placed in the "Deleted" recgroup and autoexpire is turned on.
option is configurable through the auto-expire settings page.
program should not appear from the main program list. to "undelete" the show, select the "deleted" recording group view and "undelete" the recording.
made some changes to mythweb so I can undelete the show from the "deleted" recording group.
not sure if this patch requires a myth protocol version change, since it introduces the "UNDELETE_RECORDING" command.
thoughts/comments are always welcome.
Attachments (4)
Change History (19)
by , 19 years ago
| Attachment: | expire_not_delete.diff added |
|---|
comment:1 by , 19 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
by , 19 years ago
| Attachment: | expire_not_delete.2.diff added |
|---|
by , 19 years ago
| Attachment: | expire_not_delete.3.diff added |
|---|
comment:2 by , 19 years ago
| Milestone: | unknown → 0.21 |
|---|
comment:3 by , 19 years ago
(In [14483]) Refs #3788 new feature. ability to "undelete" a recording. to turn on this feature to go the Auto expire setting window under TV Settings->General. instead of deleting a show, it is placed a "Deleted" recording group and auto expire is turned on. a "deleted" show will be auto expired before a show with a normal expiry setting. to undelete the show, access the Deleted Recording group view under the playback box, or through mythweb under the Deleted recording group section in the Recorded Programs. increments MYTH_PROTO_VERSION.
follow-up: 7 comment:4 by , 19 years ago
I need some feedback/help on reporting stats on how much space is taken by files marked for deletion. I have a single mythbackend. I'm not sure how this feature works on multiple backends.
comment:5 by , 19 years ago
When you delete a show in the "Watch Recordings" Screen the delete prompt dose not display. The prompt works fine when watching a recording.
comment:6 by , 19 years ago
comment:7 by , 19 years ago
Replying to skamithi:
I need some feedback/help on reporting stats on how much space is taken by files marked for deletion. I have a single mythbackend. I'm not sure how this feature works on multiple backends.
I was looking at this yesterday. The status reports for both the frontend and mythweb should be changed to include something like 'total space of unexpired recordings' including a handy percentage value. The overall usage is still of interest but no longer as important if one uses this patch.
Is this the sort of feedback you were after? I had hoped to get time to put a patch together but as yet that hasn't happened ...
comment:8 by , 19 years ago
| Version: | unknown → head |
|---|
comment:10 by , 19 years ago
comment:11 by , 19 years ago
by , 19 years ago
| Attachment: | ignore_programs_in_deleted_recgroups.diff added |
|---|
ignore programs in "Deleted" recgroup during scheduling checks.
comment:12 by , 19 years ago
comment:13 by , 19 years ago
comment:14 by , 19 years ago
Does the auto-expirer only expire things to free up space? If not, should probably still move things to the deleted recgroup, and only delete for real if they are already in the deleted recgroup.
comment:15 by , 19 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
I think the implementation is fairly complete with [15809], so closing the ticket as fixed
patch i've been using for the last couple of weeks.