Opened 19 years ago

Closed 19 years ago

#4055 closed patch (fixed)

Fix broken find_meta.py, handle exceptions, correctly detect if video has metadata

Reported by: matthew.d.stone@… Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: mythvideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Find_meta.py: Surround IMDB lookup with a try/catch so the import continues even if there is an error.

MythTV.py: Added a method hasMetadata(videopath). This will correctly identify whether or not a given file path has valid metadata in the myth db. I check for default category and year values and return False if they have not been changed.

imdbpy.py: Fixed a bug where sometimes the imdb module would return a movie with no Year in the key. This defaults to 1901 if that happens instead of stopping import.

Attachments (2)

scanner.patch​ (2.9 KB ) - added by matthew.d.stone@… 19 years ago.
Patch
metadata_fixes_svn_head.diff​ (1.3 KB ) - added by anonymous 19 years ago.

Download all attachments as: .zip

Change History (4)

by matthew.d.stone@…, 19 years ago

Attachment: scanner.patch​ added

Patch

by anonymous, 19 years ago

Attachment: metadata_fixes_svn_head.diff​ added

comment:1 by matthew.d.stone@…, 19 years ago

Added another patch that relies on scanner.patch to do a better job of detecting if a video that has been found honestly has metadata in the myth db. If the metadata is all set to defaults from the videomanager (category 0, year 1895), then update it with the correct metadata pulled from imdb.

Also, fixed a bug where sometimes imdb would return two identical matches. Check to see if two matches are returned and if they are identical. If so, pick the first.

comment:2 by Anduin Withers, 19 years ago

Resolution: → fixed
Status: new → closed

(In [14754]) Closes #4055

  • Handle imdbpy exceptions on lookup
  • Add hasMetadata to MythTV.py, better exiting data check
  • Handle imdbpy no year return better
  • Better duplicate result elimination

Thanks to Matthew D. Stone for this patch.

Note: See TracTickets for help on using tickets.