Streaming in mythweb doesn't work for files with special characters

[anonymous]

I use contrib/mythrename.pl to rename recordings, this breaks streaming in mythweb if the resultant filename has spaces or other special characters. This is because the invocation of ffmpeg is a simple call to open() which invokes ffmpeg in a shell. Using the 'list form' of open fixes this by invoking ffmpeg direct.

The attached 1-line patch fixes this. This will not affect streaming for people not using mythrename.pl.

Note: my perl (v5.8.8) claims that this list form of perl isn't supported on all platforms, but is supported on all platforms supporting fork and that if you're running a Unix variant you'll be OK. I've only tested this on Linux.

[mythtv-dev.spam@…]

patch to make handler.pl use list form of open to invoke ffmpeg

[Rob Smith]

What happens if we quote the filename, will that work? (escaping the quote char of course...)

[xris]

(In [16064]) open ffmpeg with list mode instead of string mode, should fix handling of international characters in filenames and close #4177

[xris]

(In [16065]) open ffmpeg with list mode instead of string mode, should fix handling of international characters in filenames and close #4177

[xris]

This commit doesn't work because of the unrecognized shell filehandle redirect.

[xris]

(In [16108]) re #4177, rethink this fix and use shell escaping so we can properly redirect stderr into nothingness.

[xris]

(In [16109]) r16108 from trunk to close #4177: rethink this fix and use shell escaping so we can properly redirect stderr into nothingness.