Opened 18 years ago
Closed 11 years ago
#4804 closed Patch - Feature (Won't Fix)
Add software amplification support to libmyth/AudioOutput
| Reported by: | Owned by: | JYA | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - Audio Output | Version: | 0.23.1 |
| Severity: | low | Keywords: | replaygain mythmusic preamp amplification gain |
| Cc: | Ticket locked: | no |
Description
In anticipation of adding ReplayGain support to MythMusic, it is required that the AudioOutput layer support software amplification.
Attachments (7)
Change History (24)
by , 18 years ago
| Attachment: | preamp-r16313.patch added |
|---|
follow-up: 2 comment:1 by , 18 years ago
I've attached a patch that adds software preamp software to AudioOutput/AudioOutputBase. The approach taken was to inplace modify all samples fed to AudioOutputBase::AddSamples. There is also some early clipping monitoring stuff in place, which could eventually be used to implement an automatic gain control if so desired.
The patch is relative to the mythtv/libs/libmyth directory of revision 16313, and can be found here.
comment:2 by , 18 years ago
Replying to chhamilton@hotmail.com:
There is also some early clipping monitoring stuff in place, which could eventually be used to implement an automatic gain control if so desired.
Another use that springs to mind is to correct for differences between mythmusic and recording volume for playback.
Haven't tried the patch but nice idea.
by , 18 years ago
| Attachment: | libs_libmyth-preamp-patch-ticket-4804.patch added |
|---|
This patch is the same patch, but against trunk as of 2008-04-14
by , 18 years ago
| Attachment: | libs_libmyth-change-pound-define-function-to-generic.patch added |
|---|
Replaces the #define APPLY_PRE_AMP with a C++ generic function
comment:3 by , 18 years ago
Probably someone will pipe up and say whether the #define or my idea for a generic function is a better idea or not. But since I would like to see this patch or something like it get into the tree, I have integrated it into my patch set and will continue to do what I can for it.
by , 18 years ago
| Attachment: | libs_libmyth-change-pound-define-function-to-generic.2.patch added |
|---|
Replaces the previous patch. There was a bug where I accidentally dropped the multiply operator
comment:4 by , 18 years ago
| Milestone: | unknown → 0.22 |
|---|---|
| Version: | unknown → head |
This functionality will definitely make it into the tree, but we're all pretty busy right now and no-one has got around to reviewing it yet.
by , 17 years ago
| Attachment: | libs_libmyth-suppress-compiler-warnings-ticket-4804.patch added |
|---|
Suppresses compiler warnings introduced in the original patch
comment:5 by , 17 years ago
I noticed that while compiling mythmusic and mythphone with the original patch in place that the introduced member functions that take values are not abstract and as such do not deal with the given parameters. The compiler throws a warning because the parameters are unused. The newly attached patch changes those member functions so that the warning is suppress. It requires the original patch (or the updated version I attached on 2008-04-14).
comment:6 by , 17 years ago
does this patch provide the possibility of making sure that the volume of AC3, mp3 etc is the same from recording to recording? Right now I have recordings in AC3 that are very quiet compared to recordings with mp3 in them.
comment:7 by , 17 years ago
| Ticket locked: | set |
|---|
comment:8 by , 16 years ago
| Component: | mythtv → MythTV - General |
|---|---|
| Milestone: | 0.22 → 0.23 |
| Ticket locked: | unset |
comment:9 by , 16 years ago
| Component: | MythTV - General → MythTV - Audio Output |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
by , 16 years ago
| Attachment: | libs_libmyth-preamp-patch-ticket-4804 added |
|---|
Same patch as before but against trunk as of 2010-02-03
by , 16 years ago
| Attachment: | libs_libmyth-preamp-patch-ticket-4804.2 added |
|---|
Same patch as before but against trunk as of 2010-02-03
comment:10 by , 16 years ago
| Milestone: | 0.23 → 0.24 |
|---|
comment:11 by , 15 years ago
| Milestone: | 0.24 → 0.25 |
|---|
ReplayGain isn't supported in mythmusic, so no much point at this stage to merge it
comment:12 by , 15 years ago
This is a minimally invasive change, and a prerequisite to ever adding ReplayGain support. Why not simply merge it now? Heck, I might even feel sufficiently motivated by that show of faith to revisit my old implementation of ReplayGain for MythMusic (built against 0.20-fixes once upon a time).
comment:13 by , 15 years ago
That patch needs to be almost fully rewritten for the new audio code. It can't be merged as is.
comment:15 by , 14 years ago
| Milestone: | 0.25 → unknown |
|---|
comment:16 by , 14 years ago
| Type: | enhancement → Patch - Feature |
|---|---|
| Version: | head → 0.23.1 |
comment:17 by , 11 years ago
| Resolution: | → Won't Fix |
|---|---|
| Status: | assigned → closed |
Don't think there is much point keeping this ticket open the patch needs to be completely rewritten for the new audio code.
Patch adding software preamp to libmyth/AudioOutput.