Opened 18 years ago

Closed 18 years ago

#5136 closed defect (invalid)

MPEGStreamData::DeleteCachedTable might try to use psip after delete

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

MPEGStreamData::DeleteCachedTable can delete psip in two seperate conditionals at lines 1394 and 1404 and then use psip at line 1416. It is unlikely. But it is probably a better idea to defer deletion until after psip is used in the look up in the list.

Attachments (1)

libs_libmythtv_mpeg_mpegstreamdata.cpp-avoid-use-after-free.patch​ (1.6 KB ) - added by Erik Hovland <erik@…> 18 years ago.
defer deleting psip until after it is used for the last time

Download all attachments as: .zip

Change History (2)

by Erik Hovland <erik@…>, 18 years ago

Attachment: libs_libmythtv_mpeg_mpegstreamdata.cpp-avoid-use-after-free.patch​ added

defer deleting psip until after it is used for the last time

comment:1 by danielk, 18 years ago

Resolution: → invalid
Status: new → closed

false positive -- the find(psip) method does not use the pointer, it's just using it as a key in a lookup table.

Note: See TracTickets for help on using tickets.