Opened 18 years ago

Closed 18 years ago

#5695 closed defect (fixed)

remove superflous memset in my_malloc

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

my_malloc will zero out buf when it knows it is a valid pointer. So the memset before that check is superflous and dangerous.

Attachments (1)

programs_mythtranscode-pointer-checks.patch​ (698 bytes ) - added by Erik Hovland <erik@…> 18 years ago.
removes unneeded memset

Download all attachments as: .zip

Change History (2)

by Erik Hovland <erik@…>, 18 years ago

Attachment: programs_mythtranscode-pointer-checks.patch​ added

removes unneeded memset

comment:1 by paulh, 18 years ago

Resolution: → fixed
Status: new → closed

(In [18312]) In my_malloc() in mythtranscode remove an unnecessary and dangerous call to memset() before the pointer from malloc() has been checked. Fixes #5695.

Note: See TracTickets for help on using tickets.