Opened 16 years ago

Closed 16 years ago

#6863 closed patch (fixed)

Segfault in MythNews when trying to visit a site that failed to retrieve news.

Reported by: Marc Alban <marcalban@…> Owned by: paulh
Priority: minor Milestone: 0.22
Component: Plugin - MythNews Version: head
Severity: medium Keywords: MythNews Segfault
Cc: Ticket locked: no

Description

Trying to visit a news site when it reports that it has failed to retrieve news results in a segfault.

This is because the check that is currently made when trying to open a site is to make sure the title value is not empty. This is no longer correct since the failure case has a title of 'Failed to retrieve news'. Checking instead on the URL resolves the issue for me.

Attachments (2)

mythnews.backtrace​ (5.1 KB ) - added by Marc Alban <marcalban@…> 16 years ago.
Backtrace of segfault in MythNews
mythnews.patch​ (586 bytes ) - added by Marc Alban <marcalban@…> 16 years ago.
Patch to fix the segfault in MythNews

Download all attachments as: .zip

Change History (6)

by Marc Alban <marcalban@…>, 16 years ago

Attachment: mythnews.backtrace​ added

Backtrace of segfault in MythNews

by Marc Alban <marcalban@…>, 16 years ago

Attachment: mythnews.patch​ added

Patch to fix the segfault in MythNews

comment:1 by paulh, 16 years ago

Owner: changed from Isaac Richards to paulh
Status: new → assigned

comment:2 by paulh, 16 years ago

The bt is showing a crash in MythBrowser not MythNews?

comment:3 by paulh, 16 years ago

(In [21952]) Fix an assert in MythBrowser when it's media handler is passed an empty string for the url. Refs #6863.

comment:4 by paulh, 16 years ago

Resolution: → fixed
Status: assigned → closed

(In [21953]) Check we have a valid url before trying to open a browser to show it. Patch from Marc Alban. Closes #6863.

Note: See TracTickets for help on using tickets.