Opened 16 years ago
Closed 16 years ago
Last modified 16 years ago
#7322 closed defect (fixed)
JumpPoints dont work in mythvideo gallery view or during gallery view playback
| Reported by: | Owned by: | Anduin Withers | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.23 |
| Component: | Plugin - MythVideo | Version: | 0.22-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
to reproduce switch to gallery view then go into a few folders and press a jump point keybinding i.e main menu or recordings
it will just move you up one directory this also happens during video playback if using gallery view.
can be reproduced in trunk and release-0-22-fixes
Attachments (1)
Change History (10)
by , 16 years ago
| Attachment: | mythvideo_jumppoints.patch added |
|---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
wow thanks heaps Jim Stichnoth I applied it to 22-fixes works cleanly and really well you made my day been waiting for someone to fix this .
comment:3 by , 16 years ago
| Component: | MythTV - General → Plugin - MythVideo |
|---|---|
| Milestone: | unknown → 0.23 |
| Owner: | changed from to |
| Version: | unknown → 0.22-fixes |
comment:4 by , 16 years ago
Sorry -- in my excitement and haste I forgot to untabify the patch. I won't bother resubmitting since it's only a one-line patch.
I got to learn how JumpPoints are implemented. Apparently an escape-key event is synthesized and continually propagated until the main menu is reached, and then the jump point is executed. This requires cooperation from the escape-key handler of each component/screen, which is supposed to check whether we are trying to exit out to the main menu. Without this patch, MythVideo isn't doing that check, so if you're at a screen that takes more than one escape key to exit out of MythVideo, JumpPoint processing gets messed up.
comment:5 by , 16 years ago
The implementation of jumppoints could be vastly improved, generating keypresses is sub-optimal. With mythui we can instead just iterate down the stacks closing screens until we reach the main menu.
comment:6 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [23085]) Fixes #7322. Allow MythVideo views with a directory-style hierarchy to respond properly to JumpPoint actions. Patch is a workaround until JumpPoints are reworked in the future. Thanks to Jim Stichnoth for the patch.
Such a minuscule patch, such a huge delta WAF...