Opened 16 years ago

Closed 14 years ago

Last modified 14 years ago

#7425 closed patch (fixed)

Mythvideo doesn't properly behaves with "Video Tree remembers last position" flag

Reported by: JYA Owned by: paulh
Priority: minor Milestone: 0.25
Component: Plugin - MythVideo Version: head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

Mythvideo can be set to remember the last position when exiting. So when you go back into mythvideo you are were you last left.

The setting: Setup -> Media Settings -> Videos -> General Settings -> Page 2 "Video tree remembers last position"

When going into Mythvideo, always back at the root of the directory.

Gallery view or Listing view

Attachments (4)

0001-Fixes-7425.-Update-tree-position-remmeber-functiona.patch (2.1 KB ) - added by mythtv@… 16 years ago.
Fixes "Save tree position" functionality in MythVideo
0001-Fixes-7425 - updated.patch (5.0 KB ) - added by mythtv@… 16 years ago.
mythvideo-remember-tree-and-gallery-position.patch (7.3 KB ) - added by Robert S 16 years ago.
Remember video position also in gallery view mode
mythvideo-remember-tree-position.patch (4.6 KB ) - added by Robert S 15 years ago.
Improved patch against trunk 24740

Download all attachments as: .zip

Change History (23)

comment:1 by robertm, 16 years ago

Component: MythTV - GeneralPlugin - MythVideo
Milestone: 0.22unknown
Owner: changed from Isaac Richards to Anduin Withers
Severity: mediumlow
Version: 0.22rc1head

comment:2 by JYA, 16 years ago

Then that option should be removed from the settings if it doesn't do anything in 0.22

comment:3 by rjmyst3@…, 16 years ago

Please don't remove the setting, but fix it instead.

I have a large video collection stored in a hierarchy of folders, and re-navigating every time I switch between videos and recordings is frustrating (more-so because my wife complains).

I really enjoyed that setting, and I am currently subscribed to updates from the 0.22-fixes through mythbuntu, so if it got fixed I could appreciate it immediately.

Is anyone able to work on this? Is this something I could reasonable create a patch for if I were to download/compile the source?

comment:4 by robertm, 16 years ago

Ticket locked: set

Discussion belongs on mailing lists.

by mythtv@…, 16 years ago

Fixes "Save tree position" functionality in MythVideo

by mythtv@…, 16 years ago

comment:5 by JYA, 16 years ago

Ticket locked: unset

comment:6 by anonymous, 16 years ago

I am very interested in this patch, since this feature is beyond useful to me, and I've missed it dearly in 0.22-fixes. If I can help out by testing it, let me know what I need to do (in 20 words or less, I'll figure out the details.) Thanks.

comment:7 by oobe.trouble@…, 16 years ago

Hi thanks heaps for the patch i tried it but it didnt seem to work

comment:8 by anonymous, 16 years ago

I just applied this to 0.22-fixes and it worked great. Thanks.

comment:9 by paulh, 16 years ago

Milestone: unknown0.23
Type: defectpatch

comment:10 by robertm, 16 years ago

Milestone: 0.230.24

in reply to:  10 comment:11 by Robert S, 16 years ago

The attached patch is against trunk revision 24017. It includes the patch from above but expands the functionality. The video position is now also remembered for the gallery view (which I use).

Robert S

by Robert S, 16 years ago

Remember video position also in gallery view mode

by Robert S, 15 years ago

Improved patch against trunk 24740

comment:12 by robertm, 15 years ago

Milestone: 0.24unknown

comment:13 by robertm, 15 years ago

Owner: changed from Anduin Withers to robertm
Status: newassigned

comment:14 by robertm, 15 years ago

Milestone: unknown0.25

comment:15 by stuartm, 15 years ago

Milestone: 0.25

Milestone 0.25 deleted

comment:16 by oobe.trouble@…, 15 years ago

Do any of these patches work with .24 fixes i tryed mythvideo-remember-tree-position.patch which applied cleanly but it didnt seem to work and 0001-Fixes-7425 - updated.patch doesnt apply cleanly which is what i was using with .23 fixes.

comment:17 by robertm, 15 years ago

Ticket locked: set

Oobe, you've been spoken to about ignoring trac rules before.

comment:18 by Github, 14 years ago

Resolution: fixed
Status: assignedclosed

MythVideo: Fix the remember position setting.

This fixes the setting to restore the same position in browser, gallery and tree views when returning to MythVideo or when switching views. Fixes #7425.

Branch: master Changeset: b03a6b6acecaf1dbd6b28c3d0ca75a66a6f0feaa

comment:19 by paulh, 14 years ago

Owner: changed from robertm to paulh
Note: See TracTickets for help on using tickets.