Opened 16 years ago
Closed 12 years ago
Last modified 6 years ago
#7486 closed Patch - Bug Fix (fixed)
DVB-C: add support for network_id override (was: Channelscanner misses some transponder)
| Reported by: | Owned by: | Stuart Auchterlonie | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.27 |
| Component: | MythTV - Channel Scanner | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I'm using the 0.22-fixes branche in a dvb-c system.
If I do a tuned full-scan, the scanner misses all channels of some transponders. If I explicity scan one of the missed transponders, all channels are found but some other transponders get missed. I don't think it's a signal problem as it always misses the same transponders.
There is another issue with the channel scanner. Not sure if this belongs into a separate ticket: If I start the channel scan a second time without restarting mythtv-setup, it gets lots of conflicting channels and asks me to asign numbers to them. This does not happen if I restart mythtv-setup after every scan.
Tell me if you need additional information for this?
Attachments (5)
Change History (52)
by , 16 years ago
| Attachment: | output.log.gz added |
|---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
The following patch fixes this issue for me. The patch allows the setting of the NIT-ID from the GUI. The setting is available from the videosource settings page.
by , 16 years ago
| Attachment: | mythtv_fix_broken_providers_with_gui.diff added |
|---|
Updated patch that will not destroy your database schema
comment:3 by , 16 years ago
| Cc: | added |
|---|
comment:4 by , 16 years ago
| Milestone: | unknown → 0.23 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
| Version: | unknown → head |
We should be able to get something like this in for 0.23
Stuart
comment:5 by , 16 years ago
by , 16 years ago
| Attachment: | mythtv_fix_broken_providers_with_gui1.diff added |
|---|
Just the above patch with the now-committed to trunk schema change removed.
comment:6 by , 16 years ago
Added a version of the above patch without the schema change. This is integrated into the GUI and still seems to function. I'm not however sure if this should be done in different classes.
comment:7 by , 16 years ago
| Milestone: | 0.23 → 0.24 |
|---|---|
| Status: | assigned → started |
Bumping this one to 0.24 as we have frozen 0.23 for new strings for translations. As this patch adds a new translatable string it needs bumping.
comment:9 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | started → accepted |
follow-up: 11 comment:10 by , 15 years ago
| Cc: | removed |
|---|---|
| Owner: | changed from to |
| Status: | accepted → assigned |
The attached patch does not seem to work. Scanning here I get two multiplexes inserted for every freq, one with the correct networkid and one without any networkid, none with the networkid I specified.
comment:11 by , 15 years ago
Replying to stuartm:
The attached patch does not seem to work. Scanning here I get two multiplexes inserted for every freq, one with the correct networkid and one without any networkid, none with the networkid I specified.
For whats it's worth. I applied the 2nd patch to my 0.23 branches and it works perfect voor DVB-C from Ziggo The Netherlands
comment:12 by , 15 years ago
I've applied the patch to mythbuntu 10.10. Besides one single line in dvbstreamdata.h the patch does still apply without other problems. This line could easy be added manually. The patched mythbuntu backend does find all channels without any problems in the Cablecom network in Switzerland. There have been some channels that where reported as duplicate, but all other channels are working. Let me know if you'd like to have further infos.
comment:13 by , 15 years ago
| Milestone: | 0.24 → 0.25 |
|---|
follow-up: 15 comment:14 by , 15 years ago
The patch can be applied on trunk svn 26882 with manual editing of dvbstreamdata.h. It works OK on cable network Ziggo in the Netherlands.
comment:15 by , 15 years ago
Replying to klaas.de.waal@…:
The patch can be applied on trunk svn 26882 with manual editing of dvbstreamdata.h. It works OK on cable network Ziggo in the Netherlands.
Too bad this got bumped to 0.25
Klaas, which of the 2 patches did you apply to 0.24 trunk? With or without the DB schema change? Could you post your amended patch here, or elaborate on your manual edit. I, and probably many others, will be using the patch on the 0.24 fixes until 0.25 arrives.
Thanks Guys, it works great.
by , 14 years ago
| Attachment: | mythtv_fix_broken_providers_with_gui.2.diff added |
|---|
Updated patch for current fixes/0.24
by , 14 years ago
| Attachment: | mythtv_fix_broken_providers_with_gui.3.diff added |
|---|
Updated patch for master/0.25 by changing VERBOSE to LOG in channelscan_sm.cpp line 205
comment:18 by , 14 years ago
This issue is over 4 years old (it replaced an older issue for some reason). It prevents me from using MythTV, since it cannot tune all my programs in Denmark. I really hope to see this in 0.25
comment:20 by , 14 years ago
| Owner: | changed from to |
|---|---|
| Priority: | minor → major |
| Ticket locked: | unset |
| Type: | defect → Patch - Bug Fix |
| Version: | head → Master Head |
comment:21 by , 14 years ago
| Status: | assigned → infoneeded |
|---|
Thanks for the patch.
Am I correct in understanding that the stream has the correct channels on an "Other Network" NIT table?
Is the modification required only at the time of scanning or is it required for regular use?
I don't really like having this hack in DVBStreamData. But we could handle this in the channel scanner itself without much difficulty.
comment:22 by , 14 years ago
| Milestone: | 0.25 → 0.26 |
|---|---|
| Owner: | changed from to |
I believe we may also need to add NIT id filtering if we allow setting a NIT id. I'm giving this one back to stuarta, since it really needs someone in a DVB country to look at it.
comment:23 by , 14 years ago
This patch allows you to do a "Full Scan (Tuned)" and find all channels in all multiplexes in mythtv-setup when the network ID is set correct in the "Video sources" page. The patch is only effective at the moment at the time of scanning in mythtv-setup. MythTV never rescans the services automatically. On my DVB-C capable TV I also need to enter the network ID, there is absolutely no way around it.
comment:24 by , 13 years ago
I used mythtv_fix_broken_providers_with_gui.3.diff today with fixes/0.25 Works like a charm, thanks a lot!
follow-up: 26 comment:25 by , 13 years ago
https://github.com/MythTV/mythtv/pull/25
This claims to fix the problem. I have not yet looked at it.
comment:26 by , 13 years ago
Replying to beirdo:
https://github.com/MythTV/mythtv/pull/25
This claims to fix the problem. I have not yet looked at it.
This one is for fixes/0.25
comment:27 by , 13 years ago
| Milestone: | 0.26 → 0.26.1 |
|---|
follow-up: 29 comment:28 by , 13 years ago
Why is the status of this ticket 'info needed'? What info is needed?
comment:29 by , 13 years ago
| Status: | infoneeded → assigned |
|---|
Replying to tycholursen@…:
Why is the status of this ticket 'info needed'? What info is needed?
Klass never marked that he provided the requested info when he responded with the info eight months ago.
comment:30 by , 12 years ago
I am on cable from UPC Cablecom Switzerland and used to have my own fix coded patches to only scan for services for a specific networkid. I examined this patch which works correct for me too. Important is, that also NIT Others has to be scanned, as my networkid only can be found in NIT Others. All televisions with DVB-C have I have seen have the possibility to specify a networkid. I hope this patch will be added for the next release.
comment:31 by , 12 years ago
| Milestone: | 0.26.1 → 0.27 |
|---|
There is a pull request that is reported to fix this.
comment:32 by , 12 years ago
| Summary: | Channelscanner misses some transponder → DVB-C: add support for network_id override (was: Channelscanner misses some transponder) |
|---|
comment:33 by , 12 years ago
Dunno what is going on, but this has supposedly been committed in https://github.com/MythTV/mythtv/commit/4d3ff242d9cef878362bd5a9cc38519ee14d91cf but I can't see it anywhere in master at this time.
wtf??
comment:34 by , 12 years ago
It was committed to the wrong repo, I'm not sure how to sort that out, without breaking the github mirror but it may just be as simple as cherry-picking from there.
comment:36 by , 12 years ago
follow-up: 38 comment:37 by , 12 years ago
This patch seems to suffer from a flaw. Some months ago I was discussing it on IRC with one of the dev's (I'm not sure who it was, I think dekarl) and he said it cocked up his channelscan.
It seemed to be a patch that would never make it into master, so I closed the pull request and moved things around a bit in my own repo
The idea is that it is disfunctional unless you give in a Nit Other. It is supposed to display '-1' out of the box and thus do nothing. In fact it displays '0' and seems to do something (according to the dev I discussed it with). I cannot test this since I'm stuck with Ziggo for provider, the one this patch was written for in the first place. So I allways give in my Nit Other.
I have had comments from Germany, Switzerland and others, stating that it solved their issues too. Of course those guys had to use a Nit Other, just like me.
comment:38 by , 12 years ago
Replying to bas-t <tycholursen@…>:
Some months ago I was discussing it on IRC with one of the dev's (I'm not sure who it was, I think dekarl) and he said it cocked up his channelscan.
yes, I brought the veto from this ticket (see comment:10) up again. But I was just the messenger :) Basically the request was to get some testing from people that do not need the patch to confirm there is no regression.
comment:42 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I have the same problem and attached a log from 'mythtv-setup -v channelscan'. MythTV does find all transports but it seems to search for channels only on the first twelve that were found in the first part of the NIT.