Mythweb Favorites not Correct for 0.22

[scottadmi@…]

The mythweb setting to only show favorite channels is broken for the current release. It refers to the no missing favorites tables. The fix is below for the mythweb file modules/tv/includes/channels.php

    function load_all_channels() {
        global $db;
        global $Channels;
        global $Callsigns;
        $Channels = array();
    // Initialize the query
        if ($_SESSION['guide_favonly'])
            $sql = 'SELECT channel.* FROM channel, channelgroup, channelgroupnames WHERE '
                  ."channelgroupnames.name='Favorites' AND channelgroupnames.grpid = channelgroup.grpid AND "
                  .'channel.chanid = channelgroup.chanid AND';
        else
            $sql = 'SELECT * FROM channel WHERE';

...

Further, a good enhancement would be to add a simple toggle to show just favorites vs. all on the listing page itself to quickly switch info.

[anonymous]

Confirm this bug and that the code provided does fix it.

[mythtv at webdeck dot com]

For what it's worth, I made this change on my installation and it fixed the problem.

[Steltek]

Same deal here: Fix works for now. In the long run, a UI to actually select from the channel groups may be needed though.

[Steltek]

Patch for channels.php with the reporter's code.

[Stuart Auchterlonie]

Bumping open 0.22 milestone tickets to 0.24

[sphery]

#8075 provides a patch to add the link to toggle favorites on the listing page.

Personally, I'd prefer this and #8075 were modified to allow users to select any of their defined channel group.

[sphery]

Closing this ticket since #8075 includes an updated patch that makes available all user-defined channel groups (and makes it available through the listings page).

[stuartm]

Also a dup of #7479