Mythweb video streaming bug incorrect fullscreen aspect

[scottadmi@…]

First, at line 52 of mythweb/modules/stream/stream.flv, the code reads:

$width = round_even(width);

This will always produce a zero result because it is missing the $ for the variable yielding a potentially wrong aspect, and should be:

$width = round_even($width);

Second, the height of the flowplayer controls are 25 pixels not 20 as written, so 25 should be used when determining the flv_h value used for the block. In the default template (modules/tv/tmpl/default/detail.php - line 30). It should be corrected as such:

$flv_h = intVal($flv_w / $program->getAspect()) + 25;  // +25px for the playback controls

Further, at full screen, the video streaming simply fills whatever screen resolution it is being viewed at, instead of filling it at the correct aspect. This can be corrected very simply by adding the following into the flowplayer script for the video (again in detail.php)

scaling: 'fit',

which will yield:

                        // Then we have the video
                        {
                            url: "<?php echo video_url($program, 'flv'); ?>",
                            duration: <?php echo $program->length ?>,
                            autoPlay: false,
                            scaling: 'fit',
                            // Would be nice to auto-buffer, but we don't want to
                            // waste bandwidth and CPU on the remote machine.
                            autoBuffering: false
                            }
                        ]}

[Stuart Auchterlonie]

Bumping open 0.22 milestone tickets to 0.24

[Rob Smith]

(In [24911]) Fixes #7538, some flash player ui improvements