mythgame makes two Calls to the Database when only one will do the job.

[Korey <k.m.fort@…>]

By replacing these:

query.exec("DELETE FROM settings WHERE value='GameDBSchemaVer';"); query.exec(QString("INSERT INTO settings (value, data, hostname) " "VALUES ('GameDBSchemaVer', %1, NULL);").arg(newnumber));

with a sigle update.

query.exec(QString("UPDATE settings SET value='GameDBSchemaVer', data=%1, hostname=NULL WHERE value='GameDBSchemaVer';").arg(newnumber));

One call to the database can be avoided. If the settings table does not have value=GameDBSchemaVer it will be created.

[Korey <k.m.fort@…>]

Trades a DELETE and INSERT for a UPDATE call to the database.

[Isaac Richards]

Might be more worthwhile to spend time on things that actually matter.

[anonymous]

mythconverg.settings.value has no unique constraint. All matching rows must be deleted if there is more than one present.

[(none)]

It still wouldn't need a unique constraint if instead of deleting the GameDBSchemaVer row everytime it just updated it. But if it won't be fixed it won't be fixed,oh well, no since in crying over spilled milk (this tickets closed)!