Opened 16 years ago
Closed 16 years ago
#7639 closed defect (fixed)
DVD: audio streams get the 'Unknown language' in audio track map
| Reported by: | Owned by: | skamithi | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - General | Version: | unknown |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Hi,
I noticed that with the DVDs I checked the codec did not set the audio language code in 'AvFormatDecoder::ScanStreams' resulting in the audio streams being saved in 'Unknown Language' internally. This does not seem to be a bigger issue as the OSD gets its information about the tracks directly via dvdnav and not via the track map.
I added some code to get the language info for the track map via dvdnav as well in case of DVDs and created a patch for this.
When testing the patch I ran into a bug that was shadowed by all audio tracks always having the unknown language: the stream selection in 'AvFormatDecoder::AutoSelectAudioTrack' exited early in case the audio map contained more than 1 language. I fixed this as well as part of the patch as it will only create more problems otherwise.
The patch is against release-0-22-fixes.
Please let me know if you need more information or testing.
Best wishes,
Martin.
Attachments (2)
Change History (5)
by , 16 years ago
| Attachment: | dvdlanguageselection.patch added |
|---|
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
by , 16 years ago
| Attachment: | dvd-audio-language-detection added |
|---|
update patch to determine audio track number via DVDRingBuffer::GetAudioTrackNum
patch to get the language code for DVD stream via dvdnav