Opened 17 years ago
Closed 15 years ago
#7857 closed Developer Task (fixed)
Replace libcdaudio freedb lookups
| Reported by: | stuartm | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | Plugin - MythMusic | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
libcdaudio is an unmaintained, five year old library which only supports an ancient version of the freedb(cddb) API. It doesn't return year or proper genre for CDs, the OSX implemention of the cd decoder does direct lookups using against freedb and does include this information. We need to move the darwin lookupCDDB() over to the base class and use that instead of going via libcdaudio.
I'd like to get this done for 0.23, but time is short so if someone else wants to have a go please speak up.
Change History (9)
comment:1 by , 16 years ago
| Milestone: | 0.23 → 0.24 |
|---|
comment:2 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 16 years ago
| Status: | assigned → accepted |
|---|
comment:4 by , 16 years ago
comment:7 by , 16 years ago
| Type: | task → Developer Task |
|---|
comment:8 by , 16 years ago
| Version: | head → Trunk Head |
|---|
This can be closed when the libcdio patch goes in.
comment:9 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
MythMusic: Use the portable libcdio for reading CDs
This patch enables MythMusic to play and rip CDs using libcdio on all platforms and also adds code to replace libcdaudio CDDB lookups.
NOTE: This removes libcdaudio and the CDDA Paranoia libraries as dependencies and adds libcdio as an optional dependency (if it's missing you wont be able to play or rip CDs). Closes #9362, #7857.
NOTE: It seems the freedb.freedb.org server is currently down so I had to do some of the testing using the musicbrainz mirror. It was working fine yesterday so I've left it hardcoded to the freedb server for now.
Branch: master Changeset: c121c3acd74a3cabfb37e22bc88ef24552e1e2e7
I've changed my mind, I think we should go with libcddb instead. It claims to be cross-platform, maybe Windows/OSX port maintainers could confirm that?