MythTV trunk compilation fixes for win32

[Jonathan Martens <jonathan@…>]

Applied patch makes MythTV trunk compile on Windows.

[Jonathan Martens <jonathan@…>]

Fixes mythtv compilation in windows (r23071)

[Jeff Lu <jll544@…>]

Re: the patch, it might be better to put the #include <time.h> in compat.h, as is done for Mac OS. The three files changed already pull in compat.h directly or indirectly.

[anonymous]

You should not remove the #define NOMINMAX from compat.h. True that mingw already defines it and generates a redefinition warning, but official win32 headers don't (e.g. compiling under VS2008). Better to leave it in - it's standard practice for dealing with windows min/max mess.

[Stuart Auchterlonie]

Does nobody learn proper use of preprocessor directives anymore?

#ifndef NOMINMAX #define NOMINMAX #endif

[Jonathan Martens <jonathan@…>]

Replying to stuarta:

Does nobody learn proper use of preprocessor directives anymore?

#ifndef NOMINMAX
#define NOMINMAX
#endif

Yes I do, but failed to do so in my patch. I was unaware that compilation on VS2008 was being achieved as well.

[Jonathan Martens <jonathan@…>]

Changes made in this patch seem to be required since [23037] etc, which is applied in order to make MythTV compile in VS2008.

I posted on the dev list to see if we can find what is the proper way to fix so MythTV will compile using MinGW as well as VS2008.

[Jonathan Martens <jonathan@…>]

Newer (less invasive) patch fixing win32 compilation using MinGW, which I hope does not brake VS2008 compilation as was noted in the development mailinglist.

[dblain]

(In [23137]) Changes to fix MinGW compile problems. Fixes #7859