Opened 16 years ago
Closed 14 years ago
Last modified 12 years ago
#7994 closed Developer Task (Fixed)
Clear the bookmark at the end of playback
| Reported by: | Owned by: | Jim Stichnoth | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.26 |
| Component: | MythTV - General | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
When exiting playback, normally the bookmark is set. However, if playback exits near the end of the recording/video, the bookmark is not set, causing inconsistent behavior next time the recording/video is played. This is because when exiting in the middle of the program, it always resumes from the same point, but when exiting at the end, the resume point depends on whether a bookmark was previously set.
It would be more consistent to always clear the bookmark when playback exits near the end. This patch does that.
Attachments (11)
Change History (27)
by , 16 years ago
| Attachment: | clear_bookmark_at_end.patch added |
|---|
by , 16 years ago
| Attachment: | clear_bookmark_at_end_2.patch added |
|---|
comment:1 by , 16 years ago
I was reminded of the frontend setting that controls whether bookmarks are saved on exit: either always, never, or after a prompt. We shouldn't mess with bookmarks unless that setting is "always". The new patch fixes this, and also tries to clean up the bookmark handling for all the calls to TV::PrepareToExitPlayer().
by , 16 years ago
| Attachment: | clear_bookmark_at_end_3.patch added |
|---|
by , 16 years ago
| Attachment: | clear_bookmark_at_end_4.patch added |
|---|
comment:3 by , 16 years ago
Updated to clear_bookmark_at_end_4.patch after the ProgramInfo refactoring.
by , 16 years ago
| Attachment: | clear_bookmark_at_end_5.patch added |
|---|
comment:4 by , 16 years ago
comment:5 by , 16 years ago
Note that clear_bookmark_at_end_5.patch is a combination of clear_bookmark_at_end_4.patch and the patch from #8527.
by , 16 years ago
| Attachment: | clear_bookmark_at_end_6.patch added |
|---|
comment:6 by , 16 years ago
Updated to clear_bookmark_at_end_6.patch after the libmythui-osd branch merge. The patch from #8527 is also needed to make this work properly for videos (as opposed to recordings).
by , 15 years ago
| Attachment: | clear_bookmark_at_end_8.patch added |
|---|
comment:7 by , 15 years ago
Updated to version 8 (must have forgotten to upload version 7) after various trunk updates, notably the NVP renaming.
comment:8 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
by , 15 years ago
| Attachment: | clear_bookmark_at_end_10.patch added |
|---|
by , 15 years ago
| Attachment: | clear_bookmark_at_end_11.patch added |
|---|
by , 15 years ago
| Attachment: | clear_bookmark_at_end_14.patch added |
|---|
Adds the logic regarding "realTotalFrames" to IsNearEnd(). This is probably worthy of a separate bug report, but it's hard to see the impact without this whole patch.
comment:9 by , 14 years ago
| Owner: | changed from to |
|---|---|
| Type: | patch → Developer Task |
comment:10 by , 14 years ago
| Milestone: | unknown → 0.26 |
|---|---|
| Version: | unknown → Master Head |
comment:13 by , 14 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | assigned → closed |
Use this instead of clear_bookmark_at_end.patch