Commercial detection runs for commercial-free channels

[sphery]

Since the ProgramInfo refactor, it seems that we only set FL_CHANCOMMFREE in the programflags when reading a RecordingInfo from the DB. So, when init_jobs() ( libs/libmythtv/tv_rec.cpp around line 3901) looks at rec->IsCommercialFree(), it always gets false (because the RI was created from a PI, not read from the DB).

From discussion on IRC: "The first thing I'd do is check if we can just load those flags in the jobqueue's PI. Alternatively we can pull it from the DB with a QueryIsCommercialFree() call."

(Leaving this at MythTV-General since it's more related to ProgramInfo than to mythcommflag.)

[danielk]

Possible fix

[danielk]

sphery, this is completely untested, but in theory should fix the problem.

[otto at kolsi dot fi]

There's a small error in scheduler.cpp part of the patch related to comma usage in SQL. I've attached patch to (only) scheduler.cpp which have these problems corrected.

With the original patch and these modifications, commfree functionality works again and I haven't seen any ill effects with limited testing. There are some other issues with commflagging but those should go to separate ticket.

[jpoet]

(In [26147]) Don't flag commercials on channels marked as comm-free.

Patch by Daniel Kristjansson with syntax fixes by Otto Kolsi.

Fixes #8491