compiling flac on windows (as a requirement for mythmusic)

[Jonathan Martens <jonathan@…>]

Although MythMusic also needs libcdaudio (which is a hard on on windows), it also requires flac.

To compile flac to errors during compilation have to be fixed, attached patch does so. I have not been able to tie it in properly into the buildscript, but I thought I'd share it here for others/future reference.

[Jonathan Martens <jonathan@…>]

Patch to make flac compile on windows

[Jonathan Martens <jonathan@…>]

Replying to Jonathan Martens <jonathan@…>:

Although MythMusic also needs libcdaudio (which is a hard on on windows), it also requires flac.

To compile flac to errors

Oops, that should have read two errors:

  In file included from stream_decoder.c:57:
  share/alloc.h:41:5: #error
  In file included from stream_decoder.c:57:
  share/alloc.h: In function `safe_malloc_mul_2op_':
  share/alloc.h:120: error: `SIZE_T_MAX' undeclared (first use in this function
  )
  share/alloc.h:120: error: (Each undeclared identifier is reported only once
  share/alloc.h:120: error: for each function it appears in.)
  share/alloc.h: In function `safe_malloc_mul_3op_':
  share/alloc.h:130: error: `SIZE_T_MAX' undeclared (first use in this function
  )
  share/alloc.h: In function `safe_malloc_mul2add_':
  share/alloc.h:143: error: `SIZE_T_MAX' undeclared (first use in this function
  )
  share/alloc.h: In function `safe_realloc_mul_2op_':
  share/alloc.h:196: error: `SIZE_T_MAX' undeclared (first use in this function
  )

main.cpp: In function 'int main(int, char**)':
main.cpp:75: error: 'memcmp' was not declared in this scope

The fixes in this patch are taken from the flac-dev mailinglist (SIZE_T_MAX: ​http://lists.xiph.org/pipermail/flac-dev/2008-August/002568.html) and the gentoo bug tracker (memcmp: ​http://bugs.gentoo.org/199579).

[robertm]

Jonathan,

I think that getting MythMusic compiling on Windows is an admirable goal, but this patch in isolation can't really be applied to anything. If you'd like to work up the changes to the build script to get and install libcdaudio, and inlike this patch like we do with the Qt stuff, please reopen. Alternately, if there's a later version that incorporates these patches (as the gentoo bug *sort of* seems to indicate, we might be able to get away with using just that. I am closing this "wontfix" for now since it's missing those components, but if you decide to work up a patch, please feel free to reopen and I will test and apply.

[Buzz]

which flac are you using? The win32-packager used to compile flac 1.2.1 just fine without any mods. If it's a problem with the headers in flac ( which this appears to be), then this should be escalated to the FLAC team.

[Jonathan Martens <jonathan@…>]

Patch to build get flac to compile from the win32 build script

[Jonathan Martens <jonathan@…>]

Replying to robertm:

I think that getting MythMusic compiling on Windows is an admirable goal

Thanks!

but this patch in isolation can't really be applied to anything. If you'd like to work up the changes to the build script to get and install libcdaudio, and inlike this patch like we do with the Qt stuff, please reopen.

Still need to do libcdaudio, but here is the flac part, re-opening.

[robertm]

This isn't going to happen for .24, I'm not going to make any more such changes to the build script until after the release.

[stuartm]

Milestone 0.25 deleted