Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#8900 closed patch (fixed)

Prefer FLAC to AC3

Reported by: anonymous Owned by: robertm
Priority: trivial Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

I have some MKVs with a FLAC and AC3 track. I'd like the FLAC track to be preferred. A better patch would also prefer PCM tracks to AC3.

Attachments (3)

mythtv_lpcm.patch​ (1.6 KB ) - added by anonymous 15 years ago.
mythtv_default.patch​ (783 bytes ) - added by anonymous 15 years ago.
prefer_flac_to_lossy_codecs.patch​ (1.2 KB ) - added by anonymous 15 years ago.

Download all attachments as: .zip

Change History (14)

by anonymous, 15 years ago

Attachment: mythtv_lpcm.patch​ added

comment:1 by anonymous, 15 years ago

MKVs seem to have a concept of a default track which MythTV appears to ignore. Respecting that would work as well.

comment:2 by robertm, 15 years ago

Priority: minor → trivial
Severity: medium → low
Status: new → infoneeded_new

FLAC is definitely not superior to all the other lossless audio codecs you put it above. (TrueHD, etc) Definitely can't make FLAC the "most preferred" audio track. Would accept a patch to use the default audio track from MKV, though.

comment:3 by robertm, 15 years ago

Owner: set to robertm

by anonymous, 15 years ago

Attachment: mythtv_default.patch​ added

comment:4 by anonymous, 15 years ago

Added a second patch to use the default audio track. Tested it by using mmg to edit the header of a MKV file.

comment:5 by robertm, 15 years ago

Milestone: unknown → 0.25
Status: infoneeded_new → new
Version: Unspecified → Trunk Head

comment:6 by robertm, 15 years ago

Status: new → assigned

comment:7 by stuartm, 15 years ago

Milestone: 0.25

Milestone 0.25 deleted

comment:8 by anonymous, 15 years ago

This more recent patch prefers TrueHD to FLAC to EAC3.

by anonymous, 15 years ago

Attachment: prefer_flac_to_lossy_codecs.patch​ added

comment:9 by robertm, 15 years ago

Resolution: → Fixed
Status: assigned → closed

Fixed in 486d2c5.

comment:10 by Robert McNamara, 15 years ago

Resolution: Fixed → fixed

Select the Default audio track if the container supports it.

Containers such as MKV permit one to define which audio track is primary, and using this flag means not going through the avformatdecoder guesswork we currently employ. This is courtesy an anonymous patch on #8900. I am uncomfortable with applying the part that prefers FLAC to E-AC3/DTS/AC3, though. There are a lot of people out there who encode secondary tracks to FLAC and do a straight copy of the lossy primary track. I just don't feel 100% on the idea of preferring it to other more commonplace codecs.

Fixes #8900.

Changeset: 486d2c5428c96d3f04b9f7d2646a823abf1bf1f7

comment:11 by stuartm, 13 years ago

Ticket locked: set
Note: See TracTickets for help on using tickets.