Opened 15 years ago

Closed 3 years ago

#9597 closed Patch - Feature (Trac EOL)

Add support for random artwork in mythui

Reported by: erictsmith@… Owned by: stuartm
Priority: minor Milestone: 29.2
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch adds support for mythui images to be pulled randomly from the fanart, coverart, and banners directories as defined by the front end mythvideo settings. It does not currently support storage groups. To use, simply add an imagestate to your ui xml and add a filename using of the special tags: %FANART% %BANNERART% or %COVERART%

Patches for fixes/0.24 and master are attached. Only the fixes/0.24 patch is tested as I do not currently have a box running master.

Attachments (4)

randomfanart_fixes24.patch (1.5 KB ) - added by erictsmith@… 15 years ago.
fixes/0.24 patch
randomfanart_master.patch (1.5 KB ) - added by erictsmith@… 15 years ago.
master patch
randomsg_fixes24.patch (2.3 KB ) - added by erictsmith@… 15 years ago.
fixes/0.24 patch with storage group support
randomsg_master.patch (2.3 KB ) - added by erictsmith@… 15 years ago.
master patch with storage group support

Download all attachments as: .zip

Change History (17)

by erictsmith@…, 15 years ago

Attachment: randomfanart_fixes24.patch added

fixes/0.24 patch

by erictsmith@…, 15 years ago

Attachment: randomfanart_master.patch added

master patch

comment:1 by robertm, 15 years ago

Owner: changed from stuartm to robertm
Status: newassigned

Patch is not acceptable, needs to support storage groups, and variable names should be "BANNERS" rather than bannerart, and screenshots need to be supported.

If you would do the preceding we can think about this, but using the legacy local locations is probably a non-starter.

comment:2 by robertm, 15 years ago

Status: assignedinfoneeded

by erictsmith@…, 15 years ago

Attachment: randomsg_fixes24.patch added

fixes/0.24 patch with storage group support

by erictsmith@…, 15 years ago

Attachment: randomsg_master.patch added

master patch with storage group support

comment:3 by erictsmith@…, 15 years ago

Status: infoneededassigned

Updated patch adds support for mythui images to be pulled randomly from any storage group. To use, simply add an imagestate to your ui xml and add a filename using of the special tag: %SG_<storage group name>%. Likely storage groups would be the special metadata groups, but any could be used. Storage group code will fall back to the Default group if the specified group does not exist and make up to 10 attempts at finding a random image file in the given group.

Patches for fixes/0.24 and master are attached. Only the fixes/0.24 patch is tested as I do not currently have a box running master.

comment:4 by Raymond Wagner, 14 years ago

Version: UnspecifiedTrunk Head

comment:5 by robertm, 13 years ago

Owner: robertm removed

comment:6 by Raymond Wagner, 13 years ago

Status: assignednew

comment:7 by stuartm, 12 years ago

Milestone: unknown0.28
Owner: set to stuartm
Status: newaccepted

comment:8 by paulh, 10 years ago

Milestone: 0.280.29

Bump to 0.29

comment:9 by Stuart Auchterlonie, 9 years ago

Milestone: 0.2929.0

Milestone renamed

comment:10 by Stuart Auchterlonie, 8 years ago

Milestone: 29.029.1

comment:11 by Stuart Auchterlonie, 8 years ago

Milestone: 29.10.28.2

Moving remaining open tickets to 0.28.2 milestone

comment:12 by Stuart Auchterlonie, 8 years ago

Milestone: 0.28.229.2

Moving remaining open tickets to 29.2 milestone

comment:13 by Stuart Auchterlonie, 3 years ago

Resolution: Trac EOL
Status: acceptedclosed

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - https://github.com/MythTV/mythtv/issues

Note: See TracTickets for help on using tickets.