couple of compile warnings - patch included

[David Buzz <buzz@…>]

Just a trivial patch to eitfixup.cpp, I'm no master coder, but it looks like someone has used a '!=' when meaning to use a '= !'. Patch below fixes the compile warning (gcc 4.0.1/fedora), but I'm not sure if I've screwed the logic up or anything.

Index: eitfixup.cpp
===================================================================
--- eitfixup.cpp        (revision 9234)
+++ eitfixup.cpp        (working copy)
@@ -290,13 +290,13 @@
         // the description as we might destroy other useful information
         captures = tmpUKCC.capturedTexts();
         for (it = captures.begin(); it != captures.end(); ++it)
-            event.SubTitled != (*it == "S");
+            event.SubTitled = !(*it == "S");
     }
     else if ((position = tmpUKCC.search(event.Event_Subtitle)) != -1)
     {
         captures = tmpUKCC.capturedTexts();
         for (it = captures.begin(); it != captures.end(); ++it)
-            event.SubTitled != (*it == "S");
+            event.SubTitled = !(*it == "S");
 
         // We remove [AD,S] from the subtitle.
         QString stmp = event.Event_Subtitle;

[David Buzz <buzz@…>]

a warning is also generated by unsigned->signed comparison in :

Index: programs/mythtranscode/replex/ringbuffer.c
===================================================================
--- programs/mythtranscode/replex/ringbuffer.c  (revision 9234)
+++ programs/mythtranscode/replex/ringbuffer.c  (working copy)
@@ -49,7 +49,7 @@
 
 int ring_reinit (ringbuffer *rbuf, int size)
 {
-       if (size > rbuf->size) {
+       if ((unsigned int)size > rbuf->size) {
                uint8_t *tmpalloc = (uint8_t *) realloc(rbuf->buffer,
                                                        sizeof(uint8_t)*size);
                if (! tmpalloc)

[David Buzz <buzz@…>]

and also in :

Index: programs/mythtranscode/mpeg2fix.cpp
===================================================================
--- programs/mythtranscode/mpeg2fix.cpp (revision 9234)
+++ programs/mythtranscode/mpeg2fix.cpp (working copy)
@@ -1853,7 +1853,7 @@
                                     PTSdiscrep = 0;
                                     break;
                                 }
-                                if (tmpPTSdiscrep != AV_NOPTS_VALUE &&
+                                if (tmpPTSdiscrep != (int64_t)AV_NOPTS_VALUE &&
                                     tmpPTSdiscrep != PTSdiscrep)
                                     PTSdiscrep = tmpPTSdiscrep;
                             }

[cpinkham]

The original eitfixup line isn't even in the code anymore. Assigning this ticket to ghaushe to see if this is how he'd prefer to fix the other warnings in mpeg2fix code.

[Isaac Richards]

(In [10027]) Close #1430 by applying warnings fix patch.