Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#3696 closed patch (invalid)

Fix some DVD import issues (Obey NAV Packets)

Reported by: anonymous Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: mythvideo Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Currently MTD does not obey NAV packets, it just reads sectors of a title sequentially.

This is a problem when importing a DVD which, for example, has a NAV packet at the end of the main title direct the player to any final credits in another title. This means that the end-credits don't get imported when importing the main title. This should also fix importing titles which include "deleted scenes" (as NAV packets are responsible for including/skipping the cells during playback).

The attached patch attempts to resolve these issues by using libdvdnav instead of libdvdread.

This is only for "perfect" or "good" quality imports and does not affect the code that handles ISO imports.

Attachments (1)

mtd.patch (12.6 KB ) - added by Bradley Kite <bradley.kite@…> 19 years ago.
Patch

Download all attachments as: .zip

Change History (4)

by Bradley Kite <bradley.kite@…>, 19 years ago

Attachment: mtd.patch added

Patch

comment:1 by Anduin Withers, 19 years ago

Component: mythtvmythvideo
Owner: changed from Isaac Richards to Anduin Withers

comment:2 by Anduin Withers, 19 years ago

Resolution: invalid
Status: newclosed

Make changes to the current read loop, the NAV packets are read and can be followed.

comment:3 by Bradley Kite <bradley.kite@…>, 19 years ago

Would this not be re-implementing what libdvdnav already does (and is already linked into the mtd binary?)

Note: See TracTickets for help on using tickets.