Opened 20 years ago
Closed 20 years ago
#395 closed patch (fixed)
Fix for imdb.pl script not picking up Genres for a movie without keywords
| Reported by: | Owned by: | jdonavan | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythvideo | Version: | head |
| Severity: | low | Keywords: | imdb |
| Cc: | Ticket locked: | no |
Description
I was poking around in this script when i saw that it would miss Genres for any movie that didn't have a "(More)" link to keywords at the end of the Genre list. For example: http://imdb.com/title/tt0390463/ would not return any Genres. The fix entails simply changing the end criteria from the "(More)" link to "User Comments" Class. Looking around at other movies, I think that this is the safest point to end the seach area for Genres. I thuoght about using Tagline wich is generaly right below Genres, but not all movies had one, also some movies had a Plot Summery while others had a Plot Outline so neither of those would work.
I'm no perl expert by any stretch so please double-check this. i tried it out on about 20 differnt movies and it gave the desired return so i'm pretty sure that it's a good fix.
Attachments (2)
Change History (7)
by , 20 years ago
| Attachment: | imdb.pl-GenreFix.diff added |
|---|
comment:1 by , 20 years ago
| Owner: | changed from to |
|---|
comment:2 by , 20 years ago
| Owner: | changed from to |
|---|
comment:3 by , 20 years ago
another 2 examplaes of imdb entries that fail.
http://www.imdb.com/title/tt0401815/ http://www.imdb.com/title/tt0416315/
the suggested patch doesn't work for me, it breaks the script. Ik you need the exact error msg please ask.
Chris
comment:4 by , 20 years ago
oops. sorry about that. I just forgot to escape out the quotes. Perl is defiantly not my native tongue. I'm upping a revised patch that should work.
by , 20 years ago
| Attachment: | imdb.pl-GenreFix.02.diff.txt added |
|---|
Chris, can you have a look at this?
perl is a foreign language to me.