"Play Recording on Frontend" doesn't work if recording "Started Early"

[ryanr23@…]

If the scheduled time is used instead of the "actual" time (in case of "Start Early" setting), the recording will not play correctly.

The starttime in the script <mythweb>/modules/tv/tmpl/default/detail.php on line 741 should change from:

... '&starttime='.urlencode($program->starttime) ...

to:

... '&starttime='.urlencode($program->recstarts) ...

[Rob Smith]

(In [24927]) Fixes #8363, this uses recstarts vs startime to find recordings

[Raymond Wagner]

Need to give an explination, or at least a contact address, if you want something re-opened.

[wombo1@…]

Hi,

I have just upgraded my Mythbuntu 10.04 system to Trunk.

I have verified that the above changes have been made to the source, but the functionality is still not working.

Below is an extract of what the browser is displaying for that line.

<div class="x-frontends">Play Recording on Frontend:<ul><li><a onclick="watchShow('htpc', '1099', '');">htpc</a><br></ul></div>

[Rob Smith]

(In [26122]) Fixes #8363, this fixes the start on frontend functionality

[jason.chambers@…]

The above fixes are incorrect.

The original description and the changes that went into [24927] had a typo in the time property - they used recstarts rather than recstartts.

This meant it didn't fix the original problem, and actually caused a new problem (comment:4) where no timestamp is included in the call to watchShow().

Then the changes in [26122] in response to comment:4 simply changed back to using starttime. Therefore it reverted to the original behaviour of ignoring any start early value and so mythweb is still unable to start playback of any such recordings.

Attached is a patch (against r27171) to fix this properly.

[jason.chambers@…]

patch referenced in comment:9

[Rob Smith]

Fixed in 6aba7cf